Skip to content

Prepare for 0.15.1 release #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 16, 2018
Merged

Prepare for 0.15.1 release #1590

merged 7 commits into from
Jan 16, 2018

Conversation

jcollins-g
Copy link
Contributor

Mostly the changelog update, however, also changed how we're importing quiver so that we work with recent changes in the SDK deps.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 10, 2018
devoncarew
devoncarew approved these changes Jan 10, 2018
View reviewed changes
pubspec.lock Outdated
@@ -408,4 +415,4 @@ packages:
source: hosted
version: "2.1.13"
sdks:
dart: ">=1.23.0 <=2.0.0-dev.15.0"
dart: ">=1.23.0 <=2.0.0-edge.f5580e540847b411bd10b6836a9f62b1c27f076f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear to me that this matters a lot, but perhaps leaving this at a dev release? (2.0.0-dev.15.0 / 2.0.0-dev.16.0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pubspec.yaml
@@ -21,6 +21,7 @@ dependencies:
mustache4dart: ^2.1.0
package_config: '>=0.1.5 <2.0.0'
path: ^1.3.0
quiver: ^0.27.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, we'd had an undeclared dep on quiver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I think we survived because tuple included it, but for some reason that has shifted to no longer work well with the SDK.

@jcollins-g
Copy link
Contributor Author

Output of DARTDOC_ORIGINAL=v0.15.0+1 grind compare-sdk-warnings

build-sdk-docs-current: Validating docs...
build-sdk-docs-original: Validating docs...
build-sdk-docs-current: found 26 warnings and 0 errors
build-sdk-docs-current: Documented 18 public libraries in 239.0 seconds
build-sdk-docs-current: Success! Docs generated into /tmp/sdkdocsQTZRDE
build-sdk-docs-original: found 26 warnings and 0 errors
build-sdk-docs-original: Documented 18 public libraries in 237.1 seconds
build-sdk-docs-original: Success! Docs generated into /tmp/sdkdocsQTZRDE
  using branch/tag: v0.15.0+1 for comparison from $DARTDOC_ORIGINAL
*** SDK docs : No difference in warning output from original (v0.15.0+1) (26 warnings found)
  
  
finished in 255.8 seconds
~/dart/dartdoc
$

@jcollins-g jcollins-g merged commit 4a009a0 into master Jan 16, 2018
@kevmoo kevmoo deleted the 0.15.1-release branch January 16, 2018 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

@keertip keertip Awaiting requested review from keertip

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcollins-g @devoncarew @googlebot